Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PASTA-ELN converters and nanoindentation file types #1

Merged
merged 10 commits into from
Apr 24, 2024

Conversation

SteffenBrinckmann
Copy link
Contributor

No description provided.

Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing I will fix, otherwise LGTM!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This directory should have the exact ID as the added filetype, I'll push to fix it

Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a couple more, guess the tests should be updated to catch this

marda_registry/data/extractors/pasta-converters.yml Outdated Show resolved Hide resolved
marda_registry/data/extractors/pasta-converters.yml Outdated Show resolved Hide resolved
@ml-evs ml-evs changed the title add Doli filetype Add PASTA-ELN converters and nanoindentation file types Apr 24, 2024
@ml-evs ml-evs merged commit 389e0a5 into datatractor:main Apr 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants